<html>
<head><meta charset="utf-8"><title>Unapproved PR in rollup · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Unapproved.20PR.20in.20rollup.html">Unapproved PR in rollup</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="214356424"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Unapproved%20PR%20in%20rollup/near/214356424" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Unapproved.20PR.20in.20rollup.html#214356424">(Oct 23 2020 at 19:32)</a>:</h4>
<p>Does anyone know what happened here? <a href="https://github.com/rust-lang/rust/pull/76649#issuecomment-715275257">https://github.com/rust-lang/rust/pull/76649#issuecomment-715275257</a></p>
<p>That PR ended up in a rollup (<a href="https://github.com/rust-lang/rust/pull/78294">https://github.com/rust-lang/rust/pull/78294</a>, cc <span class="user-mention" data-user-id="211727">@Jonas Schievink</span>) while in was in an unapproved state. I r+'d it before, but directly r-'d it again afterwards. (And r+ and r-'d it again because apparently bors reacts to edits too. ^^' But it ended with r-.) A few hours later it ends up in a few rollups.</p>
<p>Not much of a problem, as <code>r-</code> was just to squash the commits to avoid merging a merge commit. But I'm curious what went wrong. Was <code>r-</code> not enough? Or was this part of the desync problems earlier today?</p>



<a name="214356685"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Unapproved%20PR%20in%20rollup/near/214356685" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Unapproved.20PR.20in.20rollup.html#214356685">(Oct 23 2020 at 19:35)</a>:</h4>
<p>bors sometimes loses track of this when it resyncs</p>



<a name="214356811"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Unapproved%20PR%20in%20rollup/near/214356811" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Unapproved.20PR.20in.20rollup.html#214356811">(Oct 23 2020 at 19:36)</a>:</h4>
<p>It didn't complain that it was already approved when i <code>r+</code>'d it just now though. I guess it got sync'd again in the meantime and this all was just unfortunate timing.</p>



<a name="214356964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Unapproved%20PR%20in%20rollup/near/214356964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Unapproved.20PR.20in.20rollup.html#214356964">(Oct 23 2020 at 19:38)</a>:</h4>
<p>yeah, bors is... buggy</p>



<a name="214357003"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Unapproved%20PR%20in%20rollup/near/214357003" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Unapproved.20PR.20in.20rollup.html#214357003">(Oct 23 2020 at 19:38)</a>:</h4>
<p>(audited the list, all of them are actually approved)</p>



<a name="214357075"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Unapproved%20PR%20in%20rollup/near/214357075" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Unapproved.20PR.20in.20rollup.html#214357075">(Oct 23 2020 at 19:39)</a>:</h4>
<p>Okay, thanks!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>